search

DbUp / dbup-firebird

Firebird provider for DbUp
MIT License
0 stars 0 forks source link

Support creation of databases in Firebird #1

Open hhindriks opened 5 years ago

hhindriks commented 5 years ago

Support creating databases with the

EnsureDatabase.For.FirebirdDatabase(connectionString);

call. I am working on implementing them. Hopefully a PR will follow soon.

Jeern commented 10 months ago

@sungam3r and @mjauernig I always ended up implementing something like this when I have used DbUp. But its something you would only do in development or in temporary environments not in a "real" environment like production. So I am not sure it should be a part of DbUp - if so I think it should be a thing for all providers not firebird only.

Today for local development I prefer to use a docker image to create the database - it is built into the https://hub.docker.com/r/jacobalberty/firebird image so then there is no reason to do it in DbUp.

Jeern commented 10 months ago

@sungam3r and @mjauernig Hmm... I can see that EnsureDatabase is already a part of DbUp-core so then my comment is not as valid. The PR DbUp/DbUp#365 has some of the same fixes I provided in DbUp/DbUp#692

mjauernig commented 10 months ago

@Jeern So we should merge DbUp/DbUp#365 to?

Jeern commented 10 months ago

@mjauernig No not before I have taken a look at it. According to the description it would conflict with what I have already done (perhaps not in GIT but functionally)