search

De-Panther / unity-webxr-export

Develop and export WebXR experiences using Unity WebGL
https://de-panther.github.io/unity-webxr-export/
Apache License 2.0
1.01k stars 106 forks source link

fix typo and simplified boolean logic #290

Closed Thaina closed 1 year ago

Thaina commented 1 year ago

Also add JSDoc intellisense for webxr, work in vscode when trying to check the type and get suggestion for property

De-Panther commented 1 year ago

Thanks for the PR. Can you please separate the commits to different PRs? I'm not sure about the JSDoc one, but I do want to approve the typo and logic changes

Thaina commented 1 year ago

Alright

Thaina commented 1 year ago

Should the Build folder be added to gitignore too?

Or just change it into Builds folder maybe? And retroactively remove it from the history

De-Panther commented 1 year ago

If you want to build something for test, use 'Builds' or revert changes. The 'Build' folder is for the demo. I update it for releases