Mid pot and no activity beep difficultely hearable on sky9x board

[GoogleCodeExporter]

I get better results for midpot with BEEP_DEFAULT_FREQ rather than 
BEEP_DEFAULT_FREQ + 50

For no activity beep that's the second time i left my radio inactive and didn't 
hear the warning (It never happened in the old time i was using ER9X ;)

It's way better with a sound like Warn2.

Thats the same thing for AU_MIX_WARNING_1, 2 and 3, they are barely inaudible 
due to the different frequency response of the board.

Original issue reported on code.google.com by baptiste...@gadz.org on 12 Aug 2012 at 9:18

[GoogleCodeExporter]

When i say Warn2 i mean AU_FRSKY_WARN2

Original comment by baptiste...@gadz.org on 12 Aug 2012 at 9:20

[GoogleCodeExporter]

Would you send me a patch for this issue? Thanks!

Original comment by bson...@gmail.com on 27 Aug 2012 at 3:19

[GoogleCodeExporter]

Here is my patch

Original comment by baptiste...@gadz.org on 27 Aug 2012 at 3:37

Attachments:

• audio.cpp.patch

[GoogleCodeExporter]

I am ok with this patch (without the commented lines)
I asked Rob to have a look as well, Rob would you commit it if agreed and mark 
the issue as fixed?
Thanks!

Original comment by bson...@gmail.com on 27 Aug 2012 at 3:50

• Changed state: Accepted

[GoogleCodeExporter]

Cool.. will check and sort tomorrow morning :-)

Original comment by rob.maro...@googlemail.com on 27 Aug 2012 at 8:18

[GoogleCodeExporter]

Baptiste is a good tester, he found a lot of issues... If you think you will 
not have enough time to sort it, before tomorrow (I would like to release 
tomorrow) I will commit his patch and you will review it later when you have 
time, ok? Thanks!

Original comment by bson...@gmail.com on 28 Aug 2012 at 1:50

[GoogleCodeExporter]

Right!  I have submitted a patch that works around this issue for now.

Baptiste.. your fix was good - but actually missed the real source of the 
problem.

The issue was caused by a variable 'BEEP_OFFSET' being too low on the SKY9X 
board.  Changing the value of the one setting fixed the issue - and resolved 
some other beeps not being heard.

Now.. the actual source of this issue is all contained in the system menu 
'speaker pitch;.

On your radio.. I assume your pitch was set to 0?   This would have resulted in 
no sound as the offset was too low.  If you increased the setting to say.. 5.  
Sound would have started.

This has made me think that what we really need is to is make the frequency 
option a slider that can increase or decrease the pitch based on a 'norm' that 
way people can get the pitch to go either way.

I will look into this during the course of the week.

Rob

Original comment by s...@slopeside.co.uk on 29 Aug 2012 at 12:44

[GoogleCodeExporter]

You're right it's seems to be a matter of pitch:

I've also noticed that the mix warning bips (those you can choose between 1,2 
or 3) are almost inaudible: increasing the pitch helps, but for good results i 
need to be near 100 on speaker pitch.

With r1306 it's better for those bips, but still a bit low (it was far more 
audible on er9x with the original speaker)
But i don't think thoses mix bips are a big issue, since the support of voices, 
spoken messages are a better solution for warnings.

Original comment by baptiste...@gadz.org on 29 Aug 2012 at 1:56

[GoogleCodeExporter]

Curious.. it is perfectly loud on my tx!

I guess it depends on speaker combinations.

The best solution I think is that the pitch is a slider and we can 
increase/decrease the pitch to suit.

Currently it only goes one way, meaning the pitch adjustment does not suit 
every radio.

I will try sort it this week!

Rob

Original comment by s...@slopeside.co.uk on 29 Aug 2012 at 4:02

[GoogleCodeExporter]

Baptiste, are your system files played correctly on your sky9x board? Rob says 
that with current revision he doesn't have any system files played.

Original comment by bson...@gmail.com on 29 Aug 2012 at 4:21

[GoogleCodeExporter]

Which one do you want me to test r1317 ?

Original comment by baptiste...@gadz.org on 29 Aug 2012 at 4:24

[GoogleCodeExporter]

Right, on r1306 swalert.wav and thralert.wav are no more played, i have a bip 
instead.

Original comment by baptiste...@gadz.org on 29 Aug 2012 at 4:26

[GoogleCodeExporter]

Are you saying that 1306 is KO when 1305 is ok?

Original comment by bson...@gmail.com on 29 Aug 2012 at 6:17

[GoogleCodeExporter]

I've made the following tests:
r1305 -> OK (long initialisating sequence with blank screen, but voice alerts 
are played)
r1306 -> KO (fast initialisating sequence with a noisy black screen, bips 
instead of system alerts)
r1317 -> KO

Original comment by baptiste...@gadz.org on 29 Aug 2012 at 6:22

[GoogleCodeExporter]

You couldn't do better to help me, thanks a lot!

Original comment by bson...@gmail.com on 29 Aug 2012 at 6:58

[GoogleCodeExporter]

Ok it was not easy but I think r1318 is OK, would you test it as well?
Thanks!

Original comment by bson...@gmail.com on 29 Aug 2012 at 10:02

[GoogleCodeExporter]

I have seen that there is a problem with freq in tones: 8bits are not enough 
for the x2 operation, we go over 255!

Would you give a try on last revision?

Original comment by bson...@gmail.com on 29 Aug 2012 at 10:45

[GoogleCodeExporter]

Too bad: Google SVN server are down and i'm about to live home for 4 days :(

Original comment by baptiste...@gadz.org on 30 Aug 2012 at 5:14

[GoogleCodeExporter]

Still down? Here it seems ok!

Original comment by bson...@gmail.com on 30 Aug 2012 at 6:12

[GoogleCodeExporter]

It's now up, but i'm at the airport :(

Original comment by baptiste...@gadz.org on 30 Aug 2012 at 6:22

[GoogleCodeExporter]

Oh ok I will ask Rob then!

Original comment by bson...@gmail.com on 30 Aug 2012 at 6:23

[GoogleCodeExporter]

Please feel free to reopen this issue if the fix is not sufficient, thanks!

Original comment by bson...@gmail.com on 30 Aug 2012 at 3:38

• Changed state: Fixed