DeDiamondPro / Resourcify

In-game resource pack, data pack and shader browser and updater
https://modrinth.com/mod/resourcify
GNU General Public License v3.0
30 stars 6 forks source link

[Bug] Weird bug with the mod #39

Closed Anonyku05 closed 2 months ago

Anonyku05 commented 4 months ago

Technical Information Resourcify version: 1.4.0 Minecraft version: 1.20.4 Other mods (if relevant):

Describe the bug Basically, the mod make the game go weird when cheking for updates, it seem to "corrupt" the game without actually corrupting it, check the video below:

https://github.com/DeDiamondPro/Resourcify/assets/48128391/f2809d00-14a5-4142-bf43-860408c1631c

Expected behavior Must go back to ressource pack menu without any other issue.

Steps to reproduce 1- Go in a singleplayer world 2- Check for update then close

Additional information Latest log: latest.log

DeDiamondPro commented 4 months ago

Well this is new, I think this is most likely a mod conflict, (if possible) could you send the link of the modpack you are using?

Anonyku05 commented 4 months ago

It's a custom modpack i made over the last months, i can give you a link to all the mods so you can use them directly: https://mega.nz/folder/ejRAiKbS#FOHZQBZvem_5378YuVkbGA

DeDiamondPro commented 4 months ago

I'll look into it tomorrow, I appreciate you giving me the jars but for security reasons I will download them from modrinth/curseforge myself.

Anonyku05 commented 4 months ago

I was doubting you would say that, that's why i can give you the mods name list directly:

DeDiamondPro commented 4 months ago

Unfortunately I am not able to reproduce the issue.

Could you first see if you have this issue with only Resourcify. If that fixes it could you put half of your mods back in. if the issue occurs again, half your current mods folder again and see if the issue still happens if not, try the other half and repeat this process until the mod that is causing issues has been found

I know with this many mods it will probably take a while but unfortunately since I can't seem to reproduce this issue I cannot find the conflicting mod myself.

Anonyku05 commented 4 months ago

Little update but this issue seems super weird, i was able to reproduce it but didn't knew wich mod was responsible, now i removes like 50 mods and the issue was gone, i put them back alone and the issue was still gone, i put back the rest of my mods and now even with all of my modpack the issue is gone again.

It's nearly like it's with a specific configuration but can't figure out wich one cuz i used a different profile to make my tests, and now that im back on my original one the issue still occures even without joining any SP World

GrostK commented 2 months ago

I had the same bug, but to replicate that:

In singleplayer after that you will end up on game menu, the same goes for multiplayer. The mod that probably causes that is Mod Menu. But i think there is another mod, that causes to go to the main screen instead of game menu.

The list of mods here:

DeDiamondPro commented 2 months ago

Hi, thank you for providing some more information. If i do the steps you provided it opens the mod menu menu when I close the update GUI, not the main menu. I am hoping these 2 issues are caused by the same issue so fixing one should fix the other. I will start working on a fix!

DeDiamondPro commented 2 months ago

@Anonyku05 @GrostK I have implemented a fix, if you have time could you test if it also fixes your exact issue? Build is here: https://github.com/DeDiamondPro/Resourcify/actions/runs/10558411894/artifacts/1854101722 (built by github actions), jar files for all supported mc versions are in the zip. If this issue still occurs with that version, feel free to reopen this issue.

Anonyku05 commented 2 months ago

The bug is now fixed, tried the steps and nothing bad happened, thank you !

DeDiamondPro commented 2 months ago

The fix has been released in 1.4.1