Run dedop-core with Python 3.6

DeDop / dedop-core

DeDop is a User Configurable Tool for Processing Delay Doppler Altimeter Data.

http://dedop.org/

GNU General Public License v3.0

14 stars 8 forks source link

Run dedop-core with Python 3.6 #33

Closed hans-permana closed 6 years ago

hans-permana commented 7 years ago

Test dedop-core to run with Python 3.6. This is to enable using newer version of cate-util, which is about to migrate to Python 3.6.

[x] Test CLI
[x] Test webapi
[x] Test Processors
[x] Test Backend Installer

hans-permana commented 7 years ago

I created a new branch "python-36" in which I changed the environment.yml to use Python 3.6 and updated the dependencies respectively. I also did a quick test on the CLI and everything seems to work ok (I did config and workspace management, as well as running a process).

mark-ep commented 7 years ago

I've been running the unit tests in python3.6 and I've got two tests failing - for the inspect and compare scripts. In both cases it is because the module bokeh.util.platform does not have a function is_notebook.

Have you seen a similar issue at all @hans-permana ? It might well simply be a problem with the dedop/python installation in my test environment.

forman commented 6 years ago

@mark-ep So if we fix the missing is_notebook function, we can than move 3.6, right? This would be the cleanest solution for this issue.

mark-ep commented 6 years ago

yes this should fix the problem

hans-permana commented 6 years ago

Done in this merge https://github.com/DeDop/dedop-core/commit/c499e724eabbfed83b196eb25135515148b3d956. Tested with this procedure https://github.com/DeDop/dedop-core/wiki/DeDop-test-procedure-after-a-successful-build