DeFiCh / ain

DeFi Blockchain - enabling decentralized finance on Bitcoin
https://defichain.com
MIT License
408 stars 122 forks source link

Wrong Stats in getgovproposal #1721

Closed Stonygan closed 1 year ago

Stonygan commented 1 year ago

What happened:

~/.defi/defi-cli getgovproposal 8ea4991f6a8efbebbd004fe8660333bb925827415940817b413ee13a1cc594ff
{
  "proposalId": "8ea4991f6a8efbebbd004fe8660333bb925827415940817b413ee13a1cc594ff",
  "creationHeight": 2619564,
  "title": "Incentive to buy DFI by increasing negative interest on dUSD",
  "context": "https://github.com/DeFiCh/dfips/issues/245",
  "contextHash": "",
  "status": "Completed",
  "type": "VoteOfConfidence",
  "currentCycle": 1,
  "totalCycles": 1,
  "cycleEndHeight": 2633964,
  "proposalEndHeight": 2633964,
  "votingPeriod": 14400,
  "quorum": "10.00%",
  "votesPossible": 14263,
  "votesPresent": 2675,
  "votesPresentPct": "18.75%",
  "votesYes": 2564,
  "votesYesPct": "95.85%",
  "approvalThreshold": "66.67%",
  "fee": 5000.00000000,
  "options": [
    "emergency"

getgovproposal list 2675 Votes and 2564 YES-Votes. The distribution of 50% of the Fees (2500 DFI) send to 2675 Masternodes, each MN receive 0.93457943 (0.93457943x2675= 2499.9999) Compare to defiscan, there are 2685 overall Votes and 2574 YES. Difference is 10 Votes.

What you expected to happen:

Same data getgovproposal and onchain and defiscan.

defichain-bot commented 1 year ago

@Stonygan: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/ain/blob/master/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [DeFiCh/oss-governance-bot](https://github.com/DeFiCh/oss-governance-bot) repository.
prasannavl commented 1 year ago

Thanks for the report @Stonygan. We're investigating this.