search

DeFiCh / ain

DeFi Blockchain - enabling decentralized finance on Bitcoin
https://defichain.com
MIT License
401 stars 119 forks source link

`icx_makeoffer` RPC input parameter `receivePubkey` is type RPCArg::Type::NUM, should be changed to RPCArg::Type::STR #567

Closed surangap closed 3 years ago

surangap commented 3 years ago

https://github.com/DeFiCh/ain/blob/20bd608730116a5683fde678cb1a5380c05681c6/src/masternodes/rpc_icxorderbook.cpp#L369 https://github.com/DeFiCh/ain/blob/20bd608730116a5683fde678cb1a5380c05681c6/src/masternodes/rpc_icxorderbook.cpp#L180

defichain-bot commented 3 years ago

@surangap: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/ain/blob/master/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [DeFiCh/oss-governance-bot](https://github.com/DeFiCh/oss-governance-bot) repository.
fuxingloh commented 3 years ago

/kind bug /area rpc interchain-exchange /triage accepted