DeLaGuardo / setup-clojure

GitHub Action to provision clojure's most popular build tools for Linux, Mac OS X and Windows.
MIT License
187 stars 28 forks source link

Support for GHES #110

Open isaacsanders opened 1 week ago

isaacsanders commented 1 week ago

There's some complications with the use of the the action in GHES. The first of which is the use of the default token. The GHES token certainly doesn't work for public GitHub, which incidentally blocks us from getting lein installed. Being able to pass in an empty string would be helpful, but with an empty string, the "Bearer " still gets set as the auth, rather than being undefined. A lot of this gets fixed once we get an upstream github token, but that isn't always straightforward.

DeLaGuardo commented 1 week ago

What is GHES?

I think it would be safer to add an explicit option to not add an “Authorization” header instead of a blank line. Something like

      - name: Install clojure tools
        uses: DeLaGuardo/setup-clojure@12.5
        with:
          no_auth: true
          lein: 2.9.1

What do you think?

isaacsanders commented 1 week ago

GitHub Enterprise Server

isaacsanders commented 1 week ago

I think that could work well

DeLaGuardo commented 1 week ago

@isaacsanders could you try to run from the branch?

        uses: DeLaGuardo/setup-clojure@ac5052cad8ffe5039f26968da4b4a0ca88d00971
        with:
          no-auth: 'true'