search

DeLaGuardo / setup-clojure

GitHub Action to provision clojure's most popular build tools for Linux, Mac OS X and Windows.
MIT License
183 stars 27 forks source link

Refactoring: boot.exe on windows and cache for installed tools #58

Closed DeLaGuardo closed 2 years ago

DeLaGuardo commented 2 years ago

closes #57 closes #6

Added pre and post execution steps to cache installed tools.

zharinov commented 2 years ago

FYI most of pre/post handler usages I've found prefer to use same entrypoint and dispatch based on current stage. The alternative is figuring out how to build 3 different js files as entrypoints.

UPD. Though your approach looks also nice, here is my take: https://github.com/zharinov/setup-clojure/blob/test-pre-post/src/entrypoint.ts

DeLaGuardo commented 2 years ago

FYI most of pre/post handler usages I've found prefer to use same entrypoint and dispatch based on current stage. The alternative is figuring out how to build 3 different js files as entrypoints.

UPD. Though your approach looks also nice, here is my take: https://github.com/zharinov/setup-clojure/blob/test-pre-post/src/entrypoint.ts

Nice! It looks much better than building separated scripts. I'll give it a try.