search

DeLaGuardo / setup-clojure

GitHub Action to provision clojure's most popular build tools for Linux, Mac OS X and Windows.
MIT License
184 stars 27 forks source link

latest for cli should only use latest stable version #75

Closed puredanger closed 1 year ago

puredanger commented 2 years ago

I just had an issue where someone using cli: latest got the new alpha version that I released last night and are seeing issues due to changes in the alpha. The CLI has both dev and stable versions, and imo the cli: latest should only give you latest stable as we often have interim unstable releases.

I see in the code you're basing this on the Windows powershell installer version. That's probably on the path to deprecation and removal so this current strategy is likely to be broken eventually anyways. There are a couple of places you can look to find the latest stable version. One is here: https://github.com/clojure/homebrew-tools/blob/master/Formula/clojure.rb

And I have just created a new place here: https://download.clojure.org/install/stable.properties

DeLaGuardo commented 2 years ago

Thanks for the link. Very helpful! stable.properties looks fantastic. I'll adjust the action to fetch it if the "latest" version is requested.

About PowerShell installer — as far as I know, this is the only "official" way to install Clojure CLI on windows. Are you evaluating some alternatives at the moment?

puredanger commented 2 years ago

About PowerShell installer — as far as I know, this is the only "official" way to install Clojure CLI on windows. Are you evaluating some alternatives at the moment?

Yes, there is a discussion going about using an MSI installer and deps.clj. Where those would be hosted and built is still TBD.

puredanger commented 1 year ago

Thanks!