search

DeLaGuardo / setup-graalvm

MIT License
62 stars 17 forks source link

The `set-env` command is deprecated and will be disabled on November 16th. Please upgrade to using Environment Files. #7

Closed jkroepke closed 3 years ago

jkroepke commented 3 years ago

Running this action will generate a warning:

Run DeLaGuardo/setup-graalvm@3
  with:
    graalvm-version: 20.2.0.java8
  env:
    MAVEN_CLI_OPTS: -ntp --batch-mode --errors --fail-at-end --show-version -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120
    TESTCONTAINERS_RYUK_DISABLED: true
Versions of graalvm available: 
Downloading GraalVM from https://github.com/graalvm/graalvm-ce-builds/releases/download/vm-20.2.0/graalvm-ce-java8-linux-amd64-20.2.0.tar.gz
/bin/tar --version
tar (GNU tar) 1.29
Copyright (C) 2015 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by John Gilmore and Jay Fenlason.
/bin/tar xz --warning=no-unknown-keyword -C /home/runner/work/_temp/temp_844354490 -f /home/runner/work/_temp/8164c581-dce7-470f-873a-a91dc5024dc2
Error: The `set-env` command is deprecated and will be disabled on November 16th. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
Error: The `set-env` command is deprecated and will be disabled on November 16th. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
Error: The `add-path` command is deprecated and will be disabled on November 16th. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
jkroepke commented 3 years ago

I saw https://github.com/DeLaGuardo/setup-graalvm/pull/5 but there is no released version.

DeLaGuardo commented 3 years ago

Hi, please use DeLaGuardo/setup-graalvm@master to get latest stable version

jkroepke commented 3 years ago

Is master always "stable" ?

DeLaGuardo commented 3 years ago

I can say that with the same level of confidence as about tag-based releases. Here is my thoughts about GH action's releases

jkroepke commented 3 years ago

By default I do not use floating tags for actions, if possible.

You are correct. There is no difference between 3 and master. But what about a normal versioning?

If you take a look at official actions like https://github.com/actions/setup-java you could see, there is always a specific version with tag which should not override (like 1.4.3).

+

I'm using dependabot to bump specific version of actions. https://dependabot.com/github-actions/

Both in combination provides a stable CI/CD pipeline. I receive updates from action by pull requests and could test update in a branch if they still works. Thats bullet proof.

Should I open an issue for providing stable tags?

DeLaGuardo commented 3 years ago

You could use DeLaGuardo/setup-graalvm@8bbfe44ef9c6f5c07e5af036a1bffd561c037d18 as a fixed (for real) version.

Any tag (promoted as release or not) should be seeing as a floating tag because author can make them point to another commit. I understand you concerns about floating tags but unfortunately there is not so much we can do about it. Github's releases, branches and tags are not immutable.

Btw I didn't know that dependabot can check actions too. I will check how it understand which version is newest.

jkroepke commented 3 years ago

Cool, I didn't know I could use sha commit hashes as version. Thats helped me.

I guess, dependabot will not present updates in this case, but this is a more safer way then master .

Here is a output of dependabot after setting the hash as version:

updater | INFO <job_70032614> Checking if DeLaGuardo/setup-graalvm  needs updating
  proxy | 2020/11/16 16:22:45 [022] 200 https://github.com:443/DeLaGuardo/setup-graalvm.git/info/refs?service=git-upload-pack
  proxy | 2020/11/16 16:22:45 [024] GET https://github.com:443/DeLaGuardo/setup-graalvm.git/info/refs?service=git-upload-pack
  proxy | 2020/11/16 16:22:45 * authenticating git server request (host: github.com)
  proxy | 2020/11/16 16:22:45 [024] 200 https://github.com:443/DeLaGuardo/setup-graalvm.git/info/refs?service=git-upload-pack
  proxy | 2020/11/16 16:22:45 [026] GET https://api.github.com:443/repos/DeLaGuardo/setup-graalvm/compare/2.0...8bbfe44ef9c6f5c07e5af036a1bffd561c037d18
  proxy | 2020/11/16 16:22:45 * authenticating github api request
  proxy | 2020/11/16 16:22:46 [026] 200 https://api.github.com:443/repos/DeLaGuardo/setup-graalvm/compare/2.0...8bbfe44ef9c6f5c07e5af036a1bffd561c037d18
  proxy | 2020/11/16 16:22:46 [028] GET https://api.github.com:443/repos/DeLaGuardo/setup-graalvm/compare/2.0...8bbfe44ef9c6f5c07e5af036a1bffd561c037d18
  proxy | 2020/11/16 16:22:46 * authenticating github api request
  proxy | 2020/11/16 16:22:46 [028] 200 https://api.github.com:443/repos/DeLaGuardo/setup-graalvm/compare/2.0...8bbfe44ef9c6f5c07e5af036a1bffd561c037d18
updater | INFO <job_70032614> Latest version is 
  proxy | 2020/11/16 16:22:47 [030] GET https://api.github.com:443/repos/DeLaGuardo/setup-graalvm/compare/2.0...8bbfe44ef9c6f5c07e5af036a1bffd561c037d18
  proxy | 2020/11/16 16:22:47 * authenticating github api request
  proxy | 2020/11/16 16:22:47 [030] 200 https://api.github.com:443/repos/DeLaGuardo/setup-graalvm/compare/2.0...8bbfe44ef9c6f5c07e5af036a1bffd561c037d18
  proxy | 2020/11/16 16:22:47 [032] GET https://api.github.com:443/repos/DeLaGuardo/setup-graalvm/compare/2.0...8bbfe44ef9c6f5c07e5af036a1bffd561c037d18
  proxy | 2020/11/16 16:22:47 * authenticating github api request
  proxy | 2020/11/16 16:22:47 [032] 200 https://api.github.com:443/repos/DeLaGuardo/setup-graalvm/compare/2.0...8bbfe44ef9c6f5c07e5af036a1bffd561c037d18
updater | INFO <job_70032614> No update needed for DeLaGuardo/setup-graalvm
DeLaGuardo commented 3 years ago

excellent! thanks, I will have a closer look at this, maybe it would be possible to get out a difference for shas as well

marcosflobo commented 3 years ago

This workaround https://github.com/DeLaGuardo/setup-graalvm/issues/7#issuecomment-728121703 worked to me as well

mdvorak commented 3 years ago

Please provide releases, it is antipattern to use branches, and commits are very user-unfriendly. Recommended workflow is using action versions and configure Dependabot to upgrade actions as well.

Also, if you go into Marketplace listing https://github.com/marketplace/actions/setup-graalvm-environment and click on Use latest version, it offers latest Release (which is 2.0).

Thank you!

DeLaGuardo commented 3 years ago

Please use this DeLaGuardo/setup-graalvm@3.0 to get latest version. But I still suggest to use sha-based version to have really stable workflow.