search

DeMarcoLab / fibsem

A universal API for FIBSEM control
https://demarcolab.github.io/openfibsem-docs/
MIT License
27 stars 11 forks source link

[REFACTOR] Change how the pattern type is interpretted #206

Closed patrickcleeve2 closed 1 year ago

patrickcleeve2 commented 1 year ago

currently we map the pattern type from the protocol key to a predefined dict PATTERN_MILLING_MAP, but this makes adding new protocol keys required editing the code instead we should just add the pattern type to the protocol, and get it from there. wouldnt have to add to the code dictionary then.

should also take the opportunity to refactor FibsemPattern, and FibsemPatternSettings (rename mainly)

patrickcleeve2 commented 1 year ago

_get_milling_stages will now check for a key "type" to determine what kind of pattern to use