search

DeMille / encrusted

A z-machine (interpreter) for text adventure games like Zork
https://sterlingdemille.com/encrusted
MIT License
128 stars 20 forks source link

Czech z5 #12

Closed swolchok closed 5 years ago

swolchok commented 5 years ago

Fixes to pass Czech.z5.

DeMille commented 5 years ago

Dude thanks so much for showing me these czech tests and helping fix stuff! I really like being able to see that it's doing what it's supposed to! Before I was just kind of guessing and I was never quite sure if I had read the documentation the right way.

swolchok commented 5 years ago

They don’t have full coverage but they seem to be a lot better than nothing. Have you been able to build them yourself? I think I left directions in a commit message somewhere...

I have one more branch to PR that also makes czech.z8 pass. Will try to get around to that soon...

On Tue, Oct 9, 2018 at 8:20 PM Sterling DeMille notifications@github.com wrote:

Dude thanks so much for showing me these czech tests and helping fix stuff! I really like being able to see that it's doing what it's supposed to! Before I was just kind of guessing and I was never quite sure if I had read the documentation the right way.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DeMille/encrusted/pull/12#issuecomment-428396158, or mute the thread https://github.com/notifications/unsubscribe-auth/AACFeP8676SiZzNZVnUT3riVW2TqU79eks5ujT02gaJpZM4XL9Op .

DeMille commented 5 years ago

Yes, thanks for leaving those instructions, that really helped. I've built/run tests for v3 - v8 now actually. From what I've read v8 is the same as v5 except for different file size restrictions, and I think an address packing difference.