search

DeNederlandscheBank / name_matching

Other
128 stars 43 forks source link

avoiding incompatible dtype error #16

Closed ConPalos closed 10 months ago

ConPalos commented 11 months ago

The only change just changes a Series dtype from float64 to object. This Series is populated by NaN by default, which Pandas reads as a float. That's fine until the names inserted into the series are strings, which is an incompatible dtype. This doesn't change functionality, but should remove that warning (and error, whenever Pandas drops support for it).

mnijhuis-dnb commented 10 months ago

Thanks, yes to have it default to float makes no sense. Great that you corrected it!