DeNederlandscheBank / nqm

A Transformer-based Machine for answering questions on insurance companies
MIT License
0 stars 0 forks source link

quotation marks in names cause struggle in identifyingName #45

Closed jm-glowienke closed 3 years ago

jm-glowienke commented 3 years ago

Quotation marks in names have caused errors before when encoding the SPARQL queries. This was fixed by stripping quotation marks from the names, when replacing the placeholder in the question and query.

However, when building the graph ttl dataset, the quotation marks are weirdly placed in the identifyingName:

eiopa-Base:hasIdentifyingName "gravenhage",
        "l0029",
        "onderlinge levensverzekering-maatschappij \"'s-gravenhage\" u.a." ;

The name in the translated query contains no quotation marks, so this causes the query to return empty result.

TO DO:

As follow up, the evaluation on models A to H has to be rerun. Some accuracy gains should be seen. Also the gap in performance between name match and query result should decrease.