search

DeXter-on-Radix / website

Community built order book dex on Radix.
https://dexteronradix.com/
4 stars 14 forks source link

Remove console logs for rewards components #369

Open fliebenberg opened 2 weeks ago

fliebenberg commented 2 weeks ago

Some console logs were left in the code when adding the claim rewards functionality to make debugging easier if users encounter issues. These logs must be removed once the claim component has been running without issue for a couple of days.

mademoiselle-chantal commented 2 weeks ago

Hello, @fliebenberg. I want to work on this issue.

fliebenberg commented 2 weeks ago

Hi. Welcome and it is great that you want to start contributing. As I explained in the description we just need to wait until the claims component has been merged with the main branch and it is working fine before we remove the logs. For now we want to keep the logs to help with any user issues if they arise. I will comment in this issue again once we can go ahead.

mademoiselle-chantal commented 2 weeks ago

Hi. Welcome and it is great that you want to start contributing. As I explained in the description we just need to wait until the claims component has been merged with the main branch and it is working fine before we remove the logs. For now we want to keep the logs to help with any user issues if they arise. I will comment in this issue again once we can go ahead.

Understood. Otherwise, thank you for your feedback.

fliebenberg commented 1 week ago

Hi @mademoiselle-chantal I think we can go ahead now and remove the console.logs from the code. When you want to submit a PR, create a separate branch from main and make your changes in that branch and submit the branch as a PR when ready.

mademoiselle-chantal commented 4 days ago

Hello, @fliebenberg. The PR for this issue is ready. Please, tell me if l did anything wrong and I'll be here to make any changes. Thank you.