DeXter-on-Radix / website

Community built order book dex on Radix.
https://dexteronradix.com/
6 stars 14 forks source link

[BUGFIX] Prevent claiming rewards when button is disabled #405

Closed dcts closed 2 weeks ago

dcts commented 2 weeks ago

fixes #401.

cloudflare-pages[bot] commented 2 weeks ago

Deploying dexter with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3979fbc
Status: ✅  Deploy successful!
Preview URL: https://a5cbfb83.dexter-1we.pages.dev
Branch Preview URL: https://fix-rewards-page-button-bug.dexter-1we.pages.dev

View logs

yuliaSharabi commented 2 weeks ago

I am unable to test it with the preview URL - as we do not support wallet connection in preview. Or I do need some additional settings in order to retest the bug?

nguvictor commented 2 weeks ago

we do not support wallet con

It should work, are you using the stokenet version of the wallet?

nguvictor commented 2 weeks ago

@dcts I tried connecting with wallet, but got a bunch of errors. Maybe we are missing envs? image

dcts commented 2 weeks ago

@nguvictor @yuliaSharabi yes the env variables on deploy preview seem to lack the correct claim_component address it seems. To test this, can you instead fetch and checkout this branch locally and use the following mainnet env variables to test:

NEXT_PUBLIC_NETWORK=mainnet
NEXT_PUBLIC_DAPP_DEFINITION_ADDRESS=account_rdx168qrzyngejus9nazhp7rw9z3qn2r7uk3ny89m5lwvl299ayv87vpn5
NEXT_PUBLIC_DEFAULT_PAIR_ADDRESS=component_rdx1czgjmu4ed5hp0vn97ngsf6mevq9tl0v8rrh2yq0f4dnpndggk7j9pu
NEXT_PUBLIC_CLAIM_COMPONENT=component_tdx_2_1czzn503fzras55wyrs9zczxrtvf8fpytmm52rc5g3hsyx9y5dv9zzs
nguvictor commented 2 weeks ago

@nguvictor @yuliaSharabi yes the env variables on deploy preview seem to lack the correct claim_component address it seems. To test this, can you instead fetch and checkout this branch locally and use the following mainnet env variables to test:

NEXT_PUBLIC_NETWORK=mainnet
NEXT_PUBLIC_DAPP_DEFINITION_ADDRESS=account_rdx168qrzyngejus9nazhp7rw9z3qn2r7uk3ny89m5lwvl299ayv87vpn5
NEXT_PUBLIC_DEFAULT_PAIR_ADDRESS=component_rdx1czgjmu4ed5hp0vn97ngsf6mevq9tl0v8rrh2yq0f4dnpndggk7j9pu
NEXT_PUBLIC_CLAIM_COMPONENT=component_tdx_2_1czzn503fzras55wyrs9zczxrtvf8fpytmm52rc5g3hsyx9y5dv9zzs

Hey, you might of made a typo on the last address for mainnet it should be NEXT_PUBLIC_CLAIM_COMPONENT=component_rdx1cptrclw8gzm55866nas8el9jcfa8j3se7ch0fz9uq498mgy0ngn4ft

yuliaSharabi commented 2 weeks ago

Not sure I understand the instructions. If I checkout the branch do I use stokenet for it? Is it on mainnet already so we can test it on mainnet, as I see it was merged?

dcts commented 2 weeks ago

Is it on mainnet already so we can test it on mainnet

Yes its on mainnet so you can test using dexteronradix.com/rewards

yuliaSharabi commented 2 weeks ago

@dcts Retested sucsessfully! Issue can be closed.