DeXter-on-Radix / website

Community built order book dex on Radix.
https://dexteronradix.com/
Other
10 stars 21 forks source link

Order History not dimming all cancelled trades #485

Open fliebenberg opened 1 month ago

fliebenberg commented 1 month ago

In my Order History tab, not all the cancelled trades are showing as dimmed. image

dcts commented 1 month ago

@fliebenberg this is by design. Only canceled orders with no trades are dimmed, as they are essentially irrelevant. Partially filled canceled orders remain visible since trades occurred on them.

I agree this could be misleading. I had the same observation before. Is there a better, more intuitive solution, or should we keep it as is?

dcts commented 1 month ago

@maurojose can you give your input on this issue?

maurojose commented 1 month ago

true, It's confusing. As order history shows only orders that are not open, I think we could dim every cancelled order, and maybe put a button or checkbox like "hide unfilled orders"

fliebenberg commented 1 month ago

So I suggest we go with dimming all cancelled orders for now to avoid confusion. Alternatively we could have 2 levels of dimming, with only half dimming of partially filled orders. That might work, although I dont know if you will actually notice the difference.