Button [sell] for sending order is not diabled after sending TRX before it's approved in the wallet

DeXter-on-Radix / website

Community built order book dex on Radix.

https://dexteronradix.com/

Other

13 stars 21 forks source link

Button [sell] for sending order is not diabled after sending TRX before it's approved in the wallet #525

Open yuliaSharabi opened 3 months ago

yuliaSharabi commented 3 months ago

I place limit order and I can still click on the button [Limit Sell DEXTER] untill it's approved in the wallet.

yuliaSharabi commented 3 months ago

Also, creating a lot of pending TRX in the wallet connector on browser:(they are not arriving to mobile)

dcts commented 3 months ago

The issue is that transactions sometimes don't arrive in the wallet due to a bug in the Radix Wallet app or Wallet Connect extension. Implementing the suggested fix (making the button disabled) would result in a stuck transaction, requiring a page refresh to resolve. Our current solution allows users to re-trigger the transaction in hopes it reaches the wallet.

I am not sure which flow is better/worse, to me they are both equally good/bad. Maybe @maurojose has an opinion on it?

yuliaSharabi commented 3 months ago

Not sure if I got it right. After first click, why we can't diable the button for let's say 1second(giving the TRX time to arrive/fail)?