search

DeaDBeeF-Player / deadbeef

DeaDBeeF Player
https://deadbeef.sourceforge.io/
Other
1.65k stars 178 forks source link

Converter doesn't support copying album art to converted files #1684

Open Soukyuu opened 7 years ago

Soukyuu commented 7 years ago

Tried with current deadbeef master, APEv2, ID3 tags and vorbis comments. The tag itself is there according to kid3/puddletag/deadbeef, but extracting the jpg results in a 0kb file - an empty cover is displayed.

Be sure to click "refresh cover art" when testing, else the cached cover might be displayed.

Happy holidays!

Oleksiy-Yakovenko commented 7 years ago

The issue description is not quite correct. Converter doesn't load the original tags after conversion, and doesn't copy album art from them to the converted files. The only case when album art should be preserved is when you edit the tags in track properties, and don't change the tag type.

I.e. editing id3v2 should preserve the album art.

Oleksiy-Yakovenko commented 7 years ago

I guess the proper way to solve this would be to load the album art using artwork plugin, and add it to the tag before writing. This would require a new option, whether this needs to be done, and it needs to be using the new artwork plugin (which is not yet available on linux).