DeaDBeeF-Player / deadbeef

DeaDBeeF Player
https://deadbeef.sourceforge.io/
Other
1.65k stars 178 forks source link

External plugins cause Gtk:ERROR assertion when using gdk_thread_enter APIs #2112

Closed Anders1974 closed 3 years ago

Anders1974 commented 5 years ago

Steps to reproduce the problem

When playing a song, or when switching to the next song

What's going on? Describe the problem in as much detail as possible.

log Gtk:ERROR:gtktextview.c:3571:gtk_text_view_validate_onscreen: assertion failed: (text_view->onscreen_validated) Аварийный останов (стек памяти сброшен на диск)

Information about the software:

Deadbeef version: 1.8.0 OS: Arch Linux

0pLuS0 commented 4 years ago

Looks like the following weekend never came... :(

@Bfgeshka ?

Bfgeshka commented 4 years ago

Sorry about being silent, didn't see your message.

Work is in progress, I didn't forget this time actually.

0pLuS0 commented 4 years ago

@Bfgeshka I don't mean to be pushy, I've been really wanting to use the latest release, but this is the thing holding it up, sorry no pressure, but without this, we can't use the latest deadbeef and the older version of the plugin, so until then, I'm still on 0.7.2

THANKS

pkzc commented 4 years ago

Attached is a stand-alone solution based on the idea in this comment: https://github.com/DeaDBeeF-Player/deadbeef/issues/2112#issuecomment-549065609. It shows the song text in a yad window instead of in a web browser. It maintains a lyrics cache, too.

deadbeef-lyrics,txt deadbeef.txt

Rename them by chopping off .txt. Deadbeef location to be configured before use.

0pLuS0 commented 4 years ago

@Bfgeshka

Just a thought, if you think you might maintain and keep this plugin development active, have you considered putting up a Github Repo for it?

Bfgeshka commented 4 years ago

I have already made a repo for it, it's just private for now until i make this plugin working.

Due to external reasons i'm taking it slow, but work is keeping going on.

AsVHEn commented 4 years ago

@Bfgeshka Thank you for doing it.

0pLuS0 commented 4 years ago

@Bfgeshka

Hi if you're still around, going to put out an update, I realized your plugin is based on infobar-ng, not infobar. Infobar-ng, for me pulls the Biography from online and it doesn't work right, it never shows the artist image in the Bio.

Infobar works and loads the Bio from a directory, where I place the artist images and a text files containg the bio info.

For Infobar I use ~/.cache/deadbeef/bio I find this approach simpler, rather then relying on an online database....

Maybe you can consider updating Infobar to work with the latest version of deadbeef, I don't like Infobar-ng.

THANKS

alekksander commented 4 years ago

thanks for such a passion to make this work again. recently i discovered DeaDBeeF and at first look i was thrilled to find something so configurable, feature rich again, after moving to linux few years back. unfortunately some of the essence plugins i need are not working anymore, and i'm guessing they won't be picked up after such a hiatus (even file browser is on the supported list, while it's completely unreliable). hopefully infobar will work again. @0pLuS0 yes i confirm artist pictures are not loading. also lyrics need new services (like musixmatch).

Oleksiy-Yakovenko commented 4 years ago

@alekksander I wish though, that this passion went into the Infobar bugtracker instead 🤣 https://bitbucket.org/dsimbiriatin/deadbeef-infobar/issues/38/infobar-causes-deadbeef-180-to-crash

It's not me who created the Infobar, and posting to my bugtracker won't make me work on a different project (which Infobar is).

alekksander commented 4 years ago

@Alexey-Yakovenko unfortunately my contribution to open source is only about translations only. i understand this issue isn't directly linked to Your part of programming, but since it's the only place with the sign of hope (thanks to @Bfgeshka ) i decided to say a few words of support. hopefully Bfgeshka will public that source soon, so any interest can be put directly there.

0pLuS0 commented 4 years ago

@Alexey-Yakovenko

Since you are the DEV of deadbeef, you certainly know more than the rest of us, when it comes to the popularity and support your app receives.

I really love Deadbeef over all the others out there, but I see the biggest problem is the flexibility you've created into it, allowing plugins to be used of various sorts. The problem with this, as you can see, people don't stick around, and then deadbeef looses it's attraction for having this flexibility it no longer has.

I'm not sure if there is really a way, but you should have a team of developers that work strictly on the plugin side of development, so this is all done In House no more sitting around waiting on 3rd party developers, because in the end, I see it really hurts a great project like yours.

Maybe in time, as I'm suggesting it can change like this. In the meantime, thanks and keep up the great work! :)

Oleksiy-Yakovenko commented 4 years ago

I think you still don't understand the point. There's no team or "in-house" developers. It's an open-source hobby project, where volunteers can contribute patches, or for bigger things create plugins. This is the way to develop. As opposed to one monolithic app. This is also how linux distributions work. Firefox is not part of linux kernel. If firefox stops working -- the linux distribution maintainer(s) will either patch it themselves, if they have resources, or just pull it from package repository.

Plugin developers create things mainly for themselves. They can lose interest, or probably stop using deadbeef. It's exactly the same as happens with apps in commercial software world. There are tons of mobile apps that become incompatible with updated iOS or Android, and never get updated. It doesn't mean that Apple or Google or Samsung will take them in house and start working on them.

And last but not least, while the Infobar and File Browser were popular, I don't think that they hurt anything. The only real issue is having to reply to messages about it not working, and it's the only reason why I'm even considering patching it. And the only reason I'm not patching it (aside from lack of time and lack of personal interest) is that I'm not even using linux, and at the moment I don't even have a computer that can run a linux VM.

Oleksiy-Yakovenko commented 4 years ago

I deleted the heated comments, and locked the issue. If there's any update on my side - I'll post it.

Oleksiy-Yakovenko commented 3 years ago

Closing, since this is not actionable