DeaDBeeF-Player / deadbeef

DeaDBeeF Player
https://deadbeef.sourceforge.io/
Other
1.61k stars 175 forks source link

Load .cue file when opening large wav/flac/ape directly. #2131

Open dikonov opened 5 years ago

dikonov commented 5 years ago

When the user opens a wave/flac/ape/.. file directly older versions of deadbeef used to load a cue file with matching name when available. This is very convenient for flac+cue disk images.

The new version 1.8 does not do it and requires to open the cue instead of the flac to see all tracks inside. Some cue files have wrong file paths inside.

Please, add back (at least as an option) the autoloading of .cue on playing audio files.

Deadbeef version: 1.8.0 OS: Linux

Oleksiy-Yakovenko commented 5 years ago

It's impossible to add back, since this would break these use cases:

  1. opening cuesheets referencing multiple audio files
  2. opening image files without splitting them by cuesheet

Wrong paths are auto-corrected when adding the folder containing image+cue. Please let me know if there's a specific use case which you can't solve, and I will see what can be done.

dikonov commented 5 years ago

WRONG

Autoloading a cuesheet will not break point 1, if the player will either

Opening files that have a cuesheet without splitting is a valid but comparatively rare task. It can be done with a commandline option. It is quite possible to have alternative actions in file managers too by using e.g. deadbeef --nocue %p or deadbeef --loadcue %p.

Current state makes deadbeef 1.8 significanly less intuitive and less convenient.

Oleksiy-Yakovenko commented 5 years ago

Not really. Many people use deadbeef and foobar2000 interchangeably, and want the same cuesheet handling behavior, which is what I'm trying to achieve -- both from UI standpoint, and from features standpoint.

Treating cue as metadata files worked well indeed, but was blocking support of cuesheets with multiple FILE entries, and was confusing hell of a lot of users, so a special section had to be added to the help file. Most users do expect to open cue files instead of audio, when they want the splitting.

The current behavior is way less ambiguous.

dikonov commented 5 years ago

I am a proud DEADBEEF user! and I do not give a damn about foobar. I have my habits formed by deadbeef and I would like to keep it this way. Actually, I have cuesheets associated with a text editor and I never click them unless I want to edit the metadata inside.

There may be a compromise solution of having 1) a setting that would control the default behavior (autoload CUEsheets or not) 2) a commandline switch with the same effect, which would give us possibility to use it in the default command issued by the file managers upon clicking an audio file.

Oleksiy-Yakovenko commented 5 years ago

I can understand your opinion, but you should also understand what deadbeef is -- it's basically an opensource foobar2000 clone. It aims to have a very close UI/UX to foobar2000.

An option for autodetecting cuesheets can be re-implemented somehow, but currently there's no code that would do that. It's not as simple as toggling an option. This autodetection would obviously not work with tracks+cue / multiple-images+cue albums either.

So such feature looks very much like a step back to me. But anyway, if you want it -- I can keep the case open.

icher commented 3 years ago

Please let me know if there's a specific use case which you can't solve, and I will see what can be done.

For now you can't open folder with image+cue (ape+cue for example), deadbeef load only image file without cue. So, if you have few albums like this, you should open EVERY folder and select cue file. REALLY annoying. Please do something with it. Maybe new menu item like Add folder with image+cue, if you don't want change default (or foobar2000 compatible) behavior.

This autodetection would obviously not work with tracks+cue / multiple-images+cue albums either.

Well, for tracks cue is optional in most cases. They have correct tags inside. I think processing simple cases like 1 image 1 cue per folder would be just fine. In complicated cases users can select cue manually.

p.s. I don't care about foobar2000 either.

Screenshot_2021-03-05_11-32-10_15

Oleksiy-Yakovenko commented 3 years ago

For now you can't open folder with image+cue (ape+cue for example), deadbeef load only image file without cue. So, if you have few albums like this, you should open EVERY folder and select cue file. REALLY annoying.

I just tried opening a folder with ape+cue, and it works just fine, it loads correctly, both by drag-dropping a folder into playlist, and by clicking Add folder(s), and selecting one.

Oleksiy-Yakovenko commented 3 years ago

Well, for tracks cue is optional in most cases. They have correct tags inside.

It's primarily about multiple images + single cue in the same folder. I agree, that the regular tracks+cue usually don't need the cuesheet at all.

icher commented 3 years ago

I just tried opening a folder with ape+cue, and it works just fine, it loads correctly, both by drag-dropping a folder into playlist, and by clicking Add folder(s), and selecting one.

Ok, now I understand the issue: it doesn't work for symlinks. If there's no symlinks in directory path it works just fine. Checkbox Follow symlinks (Add folder dialog) doesn't work.

Oleksiy-Yakovenko commented 3 years ago

Ok, good to know. Would you be so kind to post a bug about it?

icher commented 3 years ago

Ok, good to know. Would you be so kind to post a bug about it?

2548