DeaDBeeF-Player / deadbeef

DeaDBeeF Player
https://deadbeef.sourceforge.io/
Other
1.65k stars 178 forks source link

Failed to execute the encoder #3078

Closed nsvg closed 6 months ago

nsvg commented 7 months ago

Steps to reproduce the problem

Choose a file click convert

get following error: Write error (-1 bytes written out of 8000) Failed to execute the encoder, command used: lame -V2 - "/Users/USERNAME/Music/MUSIK/Lossless/A/Anna von Hausswolff/(2020) All Thoughts Fly [FLAC]/All Thoughts Fly.mp3"

What's going on? Describe the problem in as much detail as possible.

On macos with apple silicon, converting does not work. Does not matter which format, I get the error exemplified with the file above while converting FLAC to mp3. I have installed lame separately, via homebrew and via macports. Neither seem to do the trick (I used one at a time). Have tried different directories, same issues.

On my old mac (intel i5 2020) using either deadbeef from sourceforge or from github, it converts without a problem.

Is it apple silicon that is the issue?

For the record, using media human audio converter, I can convert files without a problem on the apple silicon laptop.

Information about the software:

Deadbeef version: devel (1), from github (latest) OS: macos sonoma 14.4.1, using apple silicon (m3max)

Oleksiy-Yakovenko commented 7 months ago

Currently I don't have access to AS mac, but it should not be an issue generally, since deadbeef runs natively both on Intel and AS macs.

I can't really answer why it doesn't work, since I don't have enough details, but you can check a few things:

nsvg commented 7 months ago

Hi, Thank you for the quick reply -lame is in the PATH -I have just given deadbeef full disk access -lame runs directly from the command line

I just tried and it still does not convert

Oleksiy-Yakovenko commented 7 months ago

I will investigate as soon as I can.

nsvg commented 7 months ago

By the way, I checked on the intel mac, and deadbeef does not have full disk access, and it converts without issue.

On Wed, 10 Apr 2024 at 20:48, Oleksiy Yakovenko @.***> wrote:

I will investigate as soon as I can.

— Reply to this email directly, view it on GitHub https://github.com/DeaDBeeF-Player/deadbeef/issues/3078#issuecomment-2048219454, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANQDK6GB7OZUQEQRET7ZIMLY4WCPFAVCNFSM6AAAAABGA5POMSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBYGIYTSNBVGQ . You are receiving this because you authored the thread.Message ID: @.***>

Oleksiy-Yakovenko commented 7 months ago

Did you check that deadbeef itself is not running in Rosetta mode?

nsvg commented 7 months ago

I'll check that after work!

Den fre 12 apr. 2024 11:29Oleksiy Yakovenko @.***> skrev:

Did you check that deadbeef itself is not running in Rosetta mode?

— Reply to this email directly, view it on GitHub https://github.com/DeaDBeeF-Player/deadbeef/issues/3078#issuecomment-2051391777, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANQDK6H4IH2PG5PE67AJHATY46SP3AVCNFSM6AAAAABGA5POMSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJRGM4TCNZXG4 . You are receiving this because you authored the thread.Message ID: @.***>

nsvg commented 7 months ago

It was not running in Rosetta mode (using Rosetta mode did not change anything)

On 12. Apr 2024, at 12:36, Nicolas Velasquez @.***> wrote:

I'll check that after work!

Den fre 12 apr. 2024 11:29Oleksiy Yakovenko @. @.>> skrev:

Did you check that deadbeef itself is not running in Rosetta mode?

— Reply to this email directly, view it on GitHub https://github.com/DeaDBeeF-Player/deadbeef/issues/3078#issuecomment-2051391777, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANQDK6H4IH2PG5PE67AJHATY46SP3AVCNFSM6AAAAABGA5POMSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJRGM4TCNZXG4. You are receiving this because you authored the thread.

Oleksiy-Yakovenko commented 7 months ago

ok. I'm out of ideas for now. You're on your own until I upgrade my mac, which is probably before the end of this year. I'll ask on Discord whether anyone with AS mac is able to investigate.

nsvg commented 7 months ago

I’ll keep fiddling and trying :)

On 12. Apr 2024, at 16:11, Oleksiy Yakovenko @.***> wrote:

ok. I'm out of ideas for now. You're on your own until I upgrade my mac, which is probably before the end of this year. I'll ask on Discord whether anyone with AS mac is able to investigate.

— Reply to this email directly, view it on GitHub https://github.com/DeaDBeeF-Player/deadbeef/issues/3078#issuecomment-2051839022, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANQDK6A7R2AKHYI7IDZ6BE3Y47TPZAVCNFSM6AAAAABGA5POMSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJRHAZTSMBSGI. You are receiving this because you authored the thread.

thomasjepp commented 7 months ago

Hey - can you run which lame and post the results?

I tried this on my AS mac and the problem for me is that homebrew installs lame to /opt/homebrew/bin/lame - which isn't actually in PATH for anything other than terminals because homebrew changes PATH by adding extra bits to .zshrc and/or .zprofile.

On an intel mac, lame ends up in /usr/local/bin/lame, which I believe is in PATH by default.

nsvg commented 7 months ago

output is /opt/homebrew/bin/lame

I added manually to path (etc/paths) when installed via homebrew, still nothing. Even when installed via macports, nothing happened.

The only commands that work in the convert dialog are file cope and file move, none of the others work. Can you convert to different / any formats at all?

thomasjepp commented 7 months ago

When I was testing, I found creating a symlink pointing to /opt/homebrew/bin/lame in /usr/local/bin made it work.

Oleksiy-Yakovenko commented 7 months ago

I added manually to path (etc/paths) when installed via homebrew, still nothing.

You should probably search for a newer way of setting environment variables globally on mac. Unfortunatelly it's not trivial. Hopefully one of the solutions provided here should work: https://stackoverflow.com/questions/25385934/setting-environment-variables-via-launchd-conf-no-longer-works-in-os-x-yosemite

nsvg commented 7 months ago

Thanks for the link. For some reason on AS adding to path has not been as straightforward as it was on the intel mac, don't know why really since both are on latest sonoma. I had to use that less optimal way (etc/paths), because some python based software I use for work (xray larch) could not be added to path easily and doing it manually somehow worked.

I will try the symlink solution!

nsvg commented 7 months ago

When I was testing, I found creating a symlink pointing to /opt/homebrew/bin/lame in /usr/local/bin made it work.

it works, thanks!

Oleksiy-Yakovenko commented 7 months ago

Thanks for the investigation. I'll keep this issue open, since I would like to mitigate it somewhat.

Oleksiy-Yakovenko commented 6 months ago

Should be fixed now, converter will now add the standard homebrew and macports bin paths to the PATH env variable before trying to run the command line encoders.