DeaDBeeF-Player / deadbeef

DeaDBeeF Player
https://deadbeef.sourceforge.io/
Other
1.65k stars 178 forks source link

Building deadbeef with zlib under Ubuntu: no detection of zlib1g package #883

Closed Oleksiy-Yakovenko closed 9 years ago

Oleksiy-Yakovenko commented 9 years ago

Original issue 981 created by Alexey-Yakovenko on 2013-10-03T22:10:51.000Z:

NOTE: This is NOT a bug report.

What version of the product are you using? On what operating system and CPU architecture?

Trunk

How did you install the product?

Built it myself from source

This is a tricky one. I'm (now, yes I've changed) on Lubuntu 13.10 (b2). zlib1g and zlib1g-dev are installed (zlib1g by default, just supplemented the -dev package) and working.

However, the installation routine apparently does not look for zlib1g but only zlib1. This is likely to cause problems under Ubuntu+remixes because we would have to switch the system manually to zlib1 (which may break other applications in the process).

Is there any way out?

Oleksiy-Yakovenko commented 9 years ago

Comment #1 originally posted by Alexey-Yakovenko on 2013-10-04T07:11:28.000Z:

never heard of zlib1g before. what is the specific problem? any errors? logs? which installation routine r u talking about?

Oleksiy-Yakovenko commented 9 years ago

Comment #2 originally posted by Alexey-Yakovenko on 2013-10-04T18:48:00.000Z:

Hmmm...probably none at all, since shortly after opening this issue, I figured out that vfs_zip does NOT use zlib (which I would have made a bet on) but libzip.

Cutting it short, zlib1g is the STANDARD zlib (?)replacement(?) on Ubuntu and all derivatives. zlib is not installed by default.

Oleksiy-Yakovenko commented 9 years ago

Comment #3 originally posted by Alexey-Yakovenko on 2013-10-04T18:55:38.000Z:

so should i close this issue? i still don't understand what the problem is.

Oleksiy-Yakovenko commented 9 years ago

Comment #4 originally posted by Alexey-Yakovenko on 2013-10-06T14:57:41.000Z:

The problem is that when building the app, the configure script (or subordinate scripts called indirectly) might think "there is no zlib on the system," because at quick look, there seems no direct scan being done for the zlib1g alternative package.

But if we can ensure deadbeef will be able to live without zlib forever (and that applies to -ALL- plugins), then yes, this is no longer an issue. But I'm skeptical.

Oleksiy-Yakovenko commented 9 years ago

Comment #5 originally posted by Alexey-Yakovenko on 2013-10-06T15:02:52.000Z:

if zlib1g is a drop-in replacement lib -- then no special checks are needed. it should work just with the AC_CHECK_LIB([z], [main], [HAVE_ZLIB=yes])