DeadEnded / MotionEyeAudio

Script to add Audio to MotionEye recordings
66 stars 26 forks source link

Upgrade for Python 3 #16

Open zajaaczki opened 5 months ago

zajaaczki commented 5 months ago

Hi, first great job! I am using now docker motioneye works well! motionEye Version | 0.43.1b1 Motion Version | 4.6.0 Python 3.11.6 Could you update motioneye-audio.sh to Python 3? I tried using 2to3 and chatGPT but no lucky...

Thanks

DeadEnded commented 5 months ago

Um... are you getting an error when running this? The script is bash - it has nothing to do with python. If you are asking for the script to be converted into a python script - that is something else entirely.

As of now, I haven't used this in years - I am using other NVR software that natively supports audio. There are options available now with audio built in that IMO make this hacky approach no longer worth maintaining.

Deadend

zajaaczki commented 5 months ago

Hi Motioneye works great with h.265 codec and onvif much better than Frigate, Zoneminder, Shinobii ... that's why I still use Motioneye ;-). Yeah I am wrong is not python, my old setup was on debian and new is on alpine and maybe this is the reasone why script does not work?

DeadEnded commented 5 months ago

Okay, here's my best guess without any testing... Alpine (from my 5 second good) uses SH not BASH.

So you either need to install bash (apk update && apk add bash) OR change line one of the script from #!/usr/bin/env bash to #!/usr/bin/env sh *** NOTE - I don't know where sh is actually at... it might not be in /usr/bin/env... you need to find it and update accordingly.

Let me know how it goes! DeadEnd