DeadEnded / MotionEyeAudio

Script to add Audio to MotionEye recordings
66 stars 26 forks source link

Update motioneye-audio.sh #5

Open m1rf4k opened 4 years ago

m1rf4k commented 4 years ago

Parametrize audio codec and remove motion_gap time from audio file to avoid sound without image when motion event is over

DeadEnded commented 4 years ago

The addition of the event_gap is to trim off the excess audio of the recording correct? So your recordings currently are longer than the video capture? For users not using motion triggers, but doing continuous recording I believe this would have the effect of shortening their recordings as well, which in my experience they already are 5-10 seconds shorter than the video.

Can you please confirm you are having excess audio in your recordings? If this is the case, I think I'd only add this if we can apply it only when doing motion trigger, not continuous recording. I (eventually) want to fix the short audio on continuous recording, but since it is minimal I haven't dug into it yet.

Also, what is the reason for parameterize the audio codec? Are you using a container that does not support AAC? In my albeit short research, this appeared to be supported by most if not all containers. Hard coding this prevented merging failures due to the audio format not being supported by the container.

DeadEnd

m1rf4k commented 4 years ago

I have excess audio in my recordings, the _eventgap time. That being said, video will end before sound, leaving me with a still image while the audio is being played. The parameter for audio codec, was needed in my case for a plex app on an LG TV that was not able to play audio AAC and crashed, so I am using pcm_s16le. The container supports all formats, the app is to blame in my case.

m1rf4k

DeadEnded commented 4 years ago

Ok, I think I'll need to test the event_gap part out... on my setup with continuous recording the event_gap is default, which I guess is 30 seconds? I want to make sure that I don't lose 30 seconds of my recordings because I am doing continuous not motion triggered.

Since you have already played with this - is the event_gap always removed from the audio file? If so, I don't like this as continuous recording would lose audio at the end of their file... I think we'd have to find another way to do this like comparing the audio and video lengths and trimming the excess audio that way... just a thought.

DeadEnd