DeadSix27 / waifu2x-converter-cpp

Improved fork of Waifu2X C++ using OpenCL and OpenCV
MIT License
792 stars 86 forks source link

Occasionally corrupt output to non-png #169

Closed kattjevfel closed 5 years ago

kattjevfel commented 5 years ago

I occasionally get corrupted output when the input image is png, and output is webp or jpg, if I output to png it's all good. If I first convert the source image to something like webp (lossless) it will output fine, so I assume there's something wrong with the input file and imagemagick fixes that.

I have a feeling this is related to the newest commits as they do things different with pngs, also this was never an issue before.

i m g

source image

DeadSix27 commented 5 years ago

Can you try it with this commit: https://github.com/DeadSix27/waifu2x-converter-cpp/commit/f8d5ca0b5ac1e12a0ab863a3379e0bfd4e96b34c

Should occur there too if I'm correct.

kattjevfel commented 5 years ago

Yes, it still happens with that commit, I'll try narrow it down further though.

kattjevfel commented 5 years ago

Things break with 29467b293703e337caf17e402aa36e4f0b08e94a, previous commit is fine.

29467b293703e337caf17e402aa36e4f0b08e94a borked

9509152bdfcd23e50b9a6c020fa6fba89c749f16 fine