No VS runtime Error - Githubissues

DeadSix27 / waifu2x-converter-cpp

Improved fork of Waifu2X C++ using OpenCL and OpenCV

MIT License

792 stars 86 forks source link

No VS runtime Error #218

Closed YukihoAA closed 4 years ago

YukihoAA commented 4 years ago

as waifu2x-converter-cpp is compiled with Release option so need to include VS runtime as static lib. which was available past. need to edit some option to support it again

DeadSix27 commented 4 years ago

https://support.microsoft.com/en-us/help/2977003/the-latest-supported-visual-c-downloads ? Why static, people install this anyway for games etc. Might as well stay shared and safe some space?

YukihoAA commented 4 years ago

actually there is /MT flag so VS runtime should be included which is only includes essential runtime like 1~2KB, while w2xlib is compiled by /MT but waifu2x-converter-cpp exe is compiled by MD not MT so it is weird.

DeadSix27 commented 4 years ago

kk, I'll look into it

DeadSix27 commented 4 years ago

So did this actually work then yuki?: https://github.com/DeadSix27/waifu2x-converter-cpp/compare/master...DeadSix27:DeadSix27-mtlib-patch-1

YukihoAA commented 4 years ago

@DeadSix27

Actually not on w2xcr