Deadlock989 / IndustrialRevolution

Industrial Revolution 3 is an overhaul mod for Factorio.
51 stars 0 forks source link

Inconsistent steam assembler recipes #244

Closed Deadlock989 closed 1 year ago

Deadlock989 commented 1 year ago

Describe the bug Some recipes are set to be inaccessible to steam assemblers for thematic reasons, but it isn't being done consistently. Many things are allowed because they need to be hand-craftable, but other times things have been blocked from handcrafting by restricting them to electric assemblers, but not consistently. The apparent ban on them using lubricant (they could handle it) seems to be a big source of weirdness - if steam assemblers are allowed to assemble a nuclear reactor they should be allowed to make a conveyor belt.

Factorio version, IR version 1.1.83, 3.0.19

Other mods installed n/a

Deadlock989 commented 1 year ago

The ban on lubricant is actually because of their copper fluidbox - copper pipes can only transport water. So really any fluid recipe that doesn't involve water should be blocked, anything else that doesn't have a laser assembler restriction should be allowed.

   2.914 Script @__IndustrialRevolution3__/code/functions/functions-data-log.lua:23: IR3: WARNING: Recipe poison-capsule has category crafting-with-fluid but has sulphur-gas ingredient
   2.914 Script @__IndustrialRevolution3__/code/functions/functions-data-log.lua:23: IR3: WARNING: Recipe slowdown-capsule has category crafting-with-fluid but has lubricant ingredient
   2.914 Script @__IndustrialRevolution3__/code/functions/functions-data-log.lua:23: IR3: WARNING: Recipe flamethrower-ammo has category crafting-with-fluid but has light-oil ingredient
   2.914 Script @__IndustrialRevolution3__/code/functions/functions-data-log.lua:23: IR3: WARNING: Recipe express-transport-belt has category crafting-with-fluid but has lubricant ingredient
   2.914 Script @__IndustrialRevolution3__/code/functions/functions-data-log.lua:23: IR3: WARNING: Recipe express-transport-belt has category crafting-with-fluid but has lubricant ingredient
   2.914 Script @__IndustrialRevolution3__/code/functions/functions-data-log.lua:23: IR3: WARNING: Recipe electric-engine-unit has category crafting-with-fluid but has lubricant ingredient
   2.914 Script @__IndustrialRevolution3__/code/functions/functions-data-log.lua:23: IR3: WARNING: Recipe battery has category crafting-with-fluid but has sulfuric-acid ingredient
   2.914 Script @__IndustrialRevolution3__/code/functions/functions-data-log.lua:23: IR3: WARNING: Recipe battery has category crafting-with-fluid but has sulfuric-acid ingredient
   2.915 Script @__IndustrialRevolution3__/code/functions/functions-data-log.lua:23: IR3: WARNING: Recipe medical-pack has category crafting-with-fluid but has ethanol ingredient
   2.915 Script @__IndustrialRevolution3__/code/functions/functions-data-log.lua:23: IR3: WARNING: Recipe advanced-battery has category crafting-with-fluid but has sulfuric-acid ingredient
Deadlock989 commented 1 year ago

Re-visiting this for version 3.1.5 as many third party mods (reasonably) are going to have recipes in the crafting-with-fluid category where the fluid isn't water and in those cases, the check above is just log spam.

Solution: crafting-with-fluid removed from assembling-machine-1 crafting categories (the steam assembler). This is actually back to par with vanilla, since the vanilla grey assembler can't handle any fluids.

There are currently no IR3 assembling machine recipes that include water. But the entity will be left with the fluidboxes anyhow; if there were any such recipes or a third party mod wants to assign one to the steam assembler, they can be given the category crafting-1.