search

Deadly0 / bull-board-docker

Docker image for bull-board
https://hub.docker.com/r/deadly0/bull-board
MIT License
38 stars 47 forks source link

Add PROXY_PATH #6

Closed Diluka closed 3 years ago

Diluka commented 3 years ago

close #5

Deadly0 commented 3 years ago

@Diluka hi, what the difference between BASE_PATH and PROXY_PATH?

Diluka commented 3 years ago

@Diluka hi, what the difference between BASE_PATH and PROXY_PATH?

BASE_PATH is internal path for express server, PROXY_PATH is external path for nginx https://github.com/felixmosh/bull-board#hosting-router-on-a-sub-path

the page is SPA. so it has a base href as source link prefix https://github.com/felixmosh/bull-board/blob/master/src/ui/index.ejs#L9. PROXY_PATH tells the page how to add the link prefix.

Diluka commented 3 years ago

Added REDIS_DB config @Deadly0

patrixr commented 3 years ago

@Deadly0 @Diluka Would love to see REDIS_DB released, was looking to add that myself 👍

Diluka commented 3 years ago

@Deadly0 could you review please?

Deadly0 commented 3 years ago

@Diluka I will review soon

Diluka commented 3 years ago

@Deadly0 is there any problem?

vishalvijay commented 3 years ago

@Deadly0 Waiting for REDIS_DB to get released

Deadly0 commented 3 years ago

@Diluka sorry for delay, i'll release today