search

Deadly0 / final-form-material-ui

A set of wrapper components to facilitate using Material UI with Final Form
92 stars 33 forks source link

TextField does not animate properly #2

Open NawarA opened 5 years ago

NawarA commented 5 years ago

Bug:

Classes are not being passed down properly on focus.

For example, if you click a TextField with variant outline, the class does not get passed down properly, so no animation effect is seen when using this library. Compare the behavior of a <TextField variant=filled> with a <TextField variant=filled> from the material-ui/core and you'll notice the difference in behavior.

Easy Fix:

Fix found at: https://github.com/final-form/react-final-form/issues/294

Change inputProps to InputProps. Then everything works normally. Confirmed the fix works.

Can you please make this fix and release?

sfblaauw commented 5 years ago

Has @NawarA saids this fix the animation. Please @Deadly0 let us know if you will merge this request. Thanks

andidev commented 5 years ago

I can confirm that the fix works. From the docs Skärmavbild 2019-03-19 kl 23 10 13

I guess InputProps is the correct prop to use?

andidev commented 5 years ago

Btw this also messes up the placeholder text. It gets squashed with the label for some reason. The fix fixes this issue as well.

andidev commented 5 years ago

This bug also makes the a form value of a blank string submit as undefined (when it should submit as a blank string). The InputProps change fixes this as well.

tobytraylor commented 5 years ago

I've run into this issue as well. Thanks for the work around. One more vote for a merge.

tobytraylor commented 5 years ago

Oh no... is this project dead?

zsolt-dev commented 5 years ago

this issue is causing so many bugs and should be merged long time ago.

Is someone willing to fork this and maintain it? Or just ask @Deadly0 to replace him as a maintainer

I would do it, but I do not know typescript.