search

DeadlyBossMods / DBM-Dungeons

This mod will add support for 5 man Dungeons and World Events, spanning Classic all the way to Dragonflight, to Deadly Boss Mods (DBM).
https://www.curseforge.com/wow/addons/deadly-boss-mods-dbm-dungeons
Other
19 stars 11 forks source link

Doesn't call out to swap on Lorewalker Stonestep. #102

Closed gotex007 closed 1 year ago

gotex007 commented 1 year ago

Since the update where it's supposed to call to swap at 7 stacks, it no longer calls it out even though the option to is enabled.

MysticalOS commented 1 year ago

yeah i noticed that too, yet looked at code and found 0 issues with it, so it's not really fixable. it's literally coded to warn at 7 8 9 and 10 stacks by current code.

MysticalOS commented 1 year ago

oh are you a healer? the update disabled it by default for healers

gotex007 commented 1 year ago

It didn't do it when I tanked the key right before creating this issue so I'm not sure it's just a healer thing (would prefer it on by default). I can't remember if it triggered properly as a dps earlier today but I don't think it did.

MysticalOS commented 1 year ago

it's possible this is fixed with an update to latest core. I'll try to test it later.

MysticalOS commented 1 year ago

Confirmed fix in latest dbm core update so closing this

gotex007 commented 1 year ago

The TJS I just ran as guardian tank with the new update didn't call out to swap again. My DPS buddy also said it didn't call it out playing feral. He says it's working on his hunter though.

MysticalOS commented 1 year ago

gonna assume you haven't updated DBM core or dbm dungeons one or the other. it calls it out just fine at 7 stacks

gotex007 commented 1 year ago

Wowup keeps everything automatically updated but I'll see when I go there next. Hopefully I'm wrong and it isn't having weird issue again.

Edit: Yeah, it's working properly.