search

DeadlyBossMods / DBM-Dungeons

This mod will add support for 5 man Dungeons and World Events, spanning Classic all the way to Dragonflight, to Deadly Boss Mods (DBM).
https://www.curseforge.com/wow/addons/deadly-boss-mods-dbm-dungeons
Other
19 stars 11 forks source link

Timers off on RP event TJS 2nd Boss(Strife and Pride) #95

Closed Extort713 closed 1 year ago

Extort713 commented 1 year ago

Describe the bug

I expected that the fight would start when the RP timer finished, yet it took another 3-5s before the fight actually started. This has been a re-occurring thing that happens every time for myself.

Do you have an error log of what happened?

To Reproduce Start the fight and watch if the timer is misaligned.

Screenshots

Did you try having DeadlyBossMods as the only enabled addon and everything else (especially something like ElvUI) disabled? No

Which version of DeadlyBossMods are you using? Release

Was it working in a previous version? If yes, which was the last good one? No

MysticalOS commented 1 year ago

update dungeon mod, this is fixed in in latest update already.

gotex007 commented 1 year ago

I just ran this on my ret pally and Strife specifically wasn't calling to swap but Peril was working properly.

Edit: I ran another one today and it worked properly so I'm not sure what happened before.

MysticalOS commented 1 year ago

Works on both, based on target. if you weren't targeting it when it reached 7 stacks you got no alert. I've done this boss plenty to know it's working

gotex007 commented 1 year ago

I definitely was targeting him. Just wanted to report the occurrence. Happened all 3 times he hit 7 stacks.

Edit: I ran another one today and it worked properly so I'm not sure what happened before.

gotex007 commented 1 year ago

Works on both, based on target. if you weren't targeting it when it reached 7 stacks you got no alert. I've done this boss plenty to know it's working

It happened again today. I verified with my friends in the key that it was happening to them too. It would only call it for Peril and would not call it (not even once out of three times) on Strife. I have no idea what triggers it to do that. I mean it's not that big of a deal I guess and the season is ending soon anyway.

MysticalOS commented 1 year ago

i've done it myself, and watched it on stream, I've never seen it fail. and code wise, I see no reason for it to fail either unless for some reason the name is missing from combat log do to a missing translation. I guess I can hard code a fallback for missing name in combat log.

But the events are correct. https://www.warcraftlogs.com/reports/H32cTrWYAvyjxQV4#fight=last&pins=2%24Off%24%23244F4B%24expression%24ability.id%20%3D%20113315&view=events&translate=true

they both use same one. if it works for one, it works for both

gotex007 commented 1 year ago

Should I upload the log if it happens again? Would that help try to identify what triggers it? It's probably not worth worrying about at this point of the season but I just wanted to report that it had happened again and I verified with others that it happened at the time.

MysticalOS commented 1 year ago

nope. this issue will not be looked into at all cause it works fine for me and nothing wrong with code that logs would fix. either you have another mod breaking it, or you're encountering some obscure blizzard bug I couldn't work around anyways. I've checked every possible combat log, code path, plus fact i've done dungeon dozens of times this season with no bugs. I just can't fix what isn't broken.

gotex007 commented 1 year ago

You linked a log file which is why I asked. Like I said I don't really think it's worth caring about since it's the season is coming to an end. I just wanted to report it happening and that it wasn't just me it happened to. It doesn't even happen consistently. I'm sorry that this caused you such annoyance.