DeadlyBossMods / DBM-PvP

This mod adds support for PvP battlegrounds and arena to Deadly Boss Mods.
https://www.curseforge.com/wow/addons/dbm-pvp
Other
7 stars 7 forks source link

AV timers seems broken in wotlk #116

Closed Nillx closed 2 years ago

Nillx commented 2 years ago

Did a few AVs today and it doesnt really show any timers or if it does they are wrong. Wotlk prepatch.

sippycupmcjr commented 2 years ago

To be clear, the timers start when a team recaptures a tower/graveyard (e.g., Horde captures a bunker [no timer] and then Alliance recaptures a bunker [timer starts, "The Alliance has taken Stonehearth Bunker!" appears in chat])

dreamscape89 commented 2 years ago

The timers are broken in the pre-patch. They randomly appear and disappear, sometimes they don't appear at all.

QartemisT commented 2 years ago

This is being investigated shortly. :)

jarveson commented 2 years ago

if its any help, removing isTBC from here fixes them as far as i can tellhttps://github.com/DeadlyBossMods/DBM-PvP/blob/690609847024101dc9e551a0a97d9ec051791876/DBM-PvP/PvPGeneral.lua#L377-L385 not sure of any other changes, but looks like they swapped to retail values for this, and looks like they kept WOW_PROJECT_ID = (WOW_PROJECT_BURNING_CRUSADE_CLASSIC) for wrath :P

QartemisT commented 2 years ago

Could you try the alpha version? That was all changed to support wrath 🗡️

legoman60 commented 2 years ago

Alpha version has the same issue.

jarveson commented 2 years ago

if its ur recent commits, no https://github.com/DeadlyBossMods/DBM-PvP/blob/81e443d7f4dc1a9f7a49aa528d25de24aae24809/DBM-PvP/PvPGeneral.lua#L381

wrath is using 'retail' values here, so check should be not isRetail and not isWrath and 3 or 4 or something similar

havent checked anything else, just been grinding av :P

jarveson commented 2 years ago

also https://github.com/DeadlyBossMods/DBM-PvP/blob/81e443d7f4dc1a9f7a49aa528d25de24aae24809/DBM-PvP/PvPGeneral.lua#L514 needs to be changed from 2000 to 1600 in the three spots there for arathi

QartemisT commented 2 years ago

These have been updated in latest alpha :)

legoman60 commented 2 years ago

The most recent file on curseforge has fixed this issue (r135-9-g2923988).

MysticalOS commented 2 years ago

All BGs should be fixed. Tagged a new release and closing this issue for now since I'm pretty sure AB and AV issues all resolved.