DeadlyMC / ProtoSky

MIT License
18 stars 24 forks source link

[Bug-fix] Make glow squid spawning requirements strict #13

Closed aqnox closed 2 years ago

aqnox commented 2 years ago

After experimenting with the new release. I've noticed a major bug in glow squid spawning that causes many farms to break. In 1.18, glow squid can spawn anywhere in water under y level 30, which can lead to them clogging almost every water source in your skyblock world. This is already reported as a bug report in MC-238977, but since this is gameplay breaking, I decided to fix it now and add it as part of this mod.

The fix includes two additional checks to see whether a spawning space is within a larger body of water (like most water creatures) and whether the light level is at 0 (fits in the theme with the reason for glowing).

Here's an example of spawning conditions: 2022-02-06_16 12 25

Any feedback appreciated. I will be playing with this fix on a my own skyblock server and will see how this works out.

polarbub commented 2 years ago

I don't think this really fits in the scope of the Protosky mod.

aqnox commented 2 years ago

Fair, although I've made it available in a release on my fork here

polarbub commented 2 years ago

👍