Check discovered device has name attribute to prevent failure

Deadolus / ha-beurer

Home Assistant integration for BLE based Beurer

MIT License

12 stars 5 forks source link

Check discovered device has name attribute to prevent failure #9

Closed LandOfDodd closed 1 month ago

LandOfDodd commented 9 months ago

If discovered devices do not have a name attribute .lower will fail with:

AttributeError: 'NoneType' object has no attribute 'lower'

Fixes #8

datbilling commented 1 month ago

Could this PR be approved to fix the issue please, or has this project been abandoned? @Deadolus

Deadolus commented 1 month ago

Hmm, last time I checked ha-beurer it would have needed a complete overhault to get it working with a new HomeAssistant API - is it working for you now? Maybe this was just a fluke back then...

edit: I think https://github.com/Deadolus/ha-beurer/pull/4 fixed the issue I had - merging yours as well.

datbilling commented 1 month ago

Hmm, last time I checked ha-beurer it would have needed a complete overhault to get it working with a new HomeAssistant API - is it working for you now?

Maybe this was just a fluke back then...

edit: I think https://github.com/Deadolus/ha-beurer/pull/4 fixed the issue I had - merging yours as well.

Ah ok. No it's not working unfortunately, it doesn't discover the device. It just asks for the Name and MAC address.