Deadwood-ai / deadwood-api

Main FastAPI application for the deadwood backend
GNU General Public License v3.0
0 stars 0 forks source link

Inconsistent `name` in `v1_metadata` = `file_name` or `file_alias` ? #79

Open JesJehle opened 1 month ago

JesJehle commented 1 month ago

In the dataset table, which is created first, we add the columns file_name and file_alias. When creating the metadata fields, we also add the name column, which must be provided via the API call. However, I believe the use of name is inconsistent. We could either remove it or generate it based on the data from the dataset table, specifically using file_name or file_alias. What are your thoughts, @cmosig?

JesJehle commented 1 month ago

the name col is never actually used.

cmosig commented 1 month ago

This is confusing, I don't quite understand. What is the definition of name, file_alias, and file_name at the moment?

JesJehle commented 1 month ago

file_name = uuid + uploaded_file_name file_alias = uploaded_file_name name = (what ever you provide, in your upload script you provides file_name

cmosig commented 1 month ago

ah ok. Then removing name is a good idea I think .