search

DeamonHunter / AWBW-Replay-Player

Advance Wars By Web Replay Player
MIT License
38 stars 5 forks source link

Fog of War with Hidden Units not hiding built units #117

Closed DeamonHunter closed 1 year ago

DeamonHunter commented 1 year ago

Cynic — Today at 01:33 yo, I have a bug to report https://www.youtube.com/watch?v=uH4kfRgkoOQ&lc=UgxVjneRoZcdVETuJTh4AaABAg 20:05 minute here is the replay 738876.zip

It seems units aren't being hidden after being built. There should probably be a test for this so it doesn't break again.

DeamonHunter commented 1 year ago

This was caused by replays not containing actions for units attacking pipes. The steps to replicate this was:

  1. Have a unit move towards a pipe and attack it.
  2. Have a unit move/be built on the position the previous unit was.
  3. It would set only 1 of 2 units hidden, typically the first one.

This has been fixed in 61901698e33cc765e0f166e9933bcbfdd6413312