DeamonHunter / AWBW-Replay-Player

Advance Wars By Web Replay Player
MIT License
38 stars 5 forks source link

[BUG] Attacking a pipeseam has become an action #139

Closed bataneske closed 7 months ago

bataneske commented 7 months ago

February 13th marked an end to an era - new replays on advance wars will register attacks against pipe seams! Great news for sure, but it breaks all new replays that have any offense against pipe seams.

To reproduce

Here's the exact replay I used: 1114245.zip Dragging and dropping will cause throw an error: Failed to parse replay Action 2 on Turn 13, Day 7 (...) Unknown replay action type: AttackSeam

You can check the intended action on the web version, here's the link to replay's Day 13: https://awbw.amarriner.com/game.php?games_id=1114245&ndx=13 Measly infantry doing 1HP damage to a pipe! Untitled Who could have known that would be the strongest unit in Advance Wars?

Welp, hopefully it's not a big problem to solve, since it flat out refuses to load new replays. And if you want more work for whatever reason, I found a script that lets you download archived replays, but there's a type mismatch in the archive. I can open an issue for it, and if not, I might look into it some day, although I haven't touched C# ever since Kanbei lost his socks.