search

DeamonHunter / AWBW-Replay-Player

Advance Wars By Web Replay Player
MIT License
38 stars 5 forks source link

Added AttackSeam to Actions #140

Closed Nabelon closed 8 months ago

Nabelon commented 8 months ago

Fixes https://github.com/DeamonHunter/AWBW-Replay-Player/issues/139

Known issues:

  1. when undoing to a previous turn, units that attacked the pipeseam are not greyes out
  2. desync errors: Destroyed pipe seams can have different CP values, sometimes they are at 20 CP and sometimes at the last CP before the pipeseam was destroyed, couldnt figure out why
DeamonHunter commented 8 months ago

Hi thanks for doing this!

I've gone ahead and merged this in, with some changes. Mostly minor stuff like adding in animations, format cleanup. Did end up fixing the bugs you meantioned. (Though might've added more... haha)

  1. This was caused by not setting unit.TimesMoved = 1; in the SetupAndUpdate method. Its admittedly a bit jank that it doesn't pick up based on firing.
  2. Found a cause of desync, when returning a building back to normal, it didn't set the capture value at all. Starting at GameMap Line 667.
Nabelon commented 8 months ago

No problem, thanks for making the tool in the first place ^^