DeamonHunter / AWBW-Replay-Player

Advance Wars By Web Replay Player
MIT License
38 stars 5 forks source link

Fixed Desync issue for Neotanks and destroyed Pipeseams #141

Closed Nabelon closed 4 months ago

Nabelon commented 6 months ago

The neotank desync was caused by 'FuelUsagePerTurn' being set to 1 instead of 0.

CP of destroyed pipeseams is basically undefined, so I removed them from the equality check for buildings. How AWBW handles them is inconsistent; in the LL games I checked, the following happens:

However, in one of my test games (ID: 1121885), the CP is set to 20 in the turn the seam is destroyed.

Nabelon commented 6 months ago

Im not really happy with my solution to "fix" the pipe seam desync but when I asked in the discord why this weird behavior occurs i got no response. Adding code that sets destroyed pipeseams CP to 20 at the start of a turn also seems kinda pointless, much easier to say CP is undefined and not check it when comparing pipe seams

Nabelon commented 5 months ago

(I have no clue what the established convention for push requests is; it's my first time doing this, so feel free to comment if it should be done differently.)

Press enter to login: Just a minor issue I had using the app.

Added Clock: Go7 said something about it in the stream;. With the addition of live league, it feels like a good idea to add. While writing the clock, I noticed that: a) old code wasn't working as intended and always jumped into the "teams exist" condition (the team of a player is an integer in e.g. live league and not null). b) Truncate=true doesn't work. Either that or the containers overlap. UIs are not my strong suit. I am unsure whether I should just ignore it or take a prefix of the player name.