search

DeanHere / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

closed=3 in search URL is not intuitive #298

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Try to get link to search for all opened issues in Rietveld
2. It will be 
http://codereview.appspot.com/search?base=http://rietveld.googlecode.com/svn/tru
nk/&closed=3

What is the expected output? What do you see instead?
I expect ...trunk/&closed=0 or ...trunk/&closed=false, but not 
...trunk/&closed=3

Please provide any additional information below.
After the fix (if any), won't forget to update link on [Contributing] wiki page.

Original issue reported on code.google.com by techtonik@gmail.com on 29 Apr 2011 at 2:34

GoogleCodeExporter commented 9 years ago 
That's by design, see:
https://docs.djangoproject.com/en/dev/ref/forms/fields/#booleanfield

Original comment by maruel@chromium.org on 7 Jan 2012 at 9:58

GoogleCodeExporter commented 9 years ago 
And what should I look for? There is no explanation why GET parameter for 
"false" value is equal to 3 "by design". In fact the proposal to change this 
was accepted at https://code.djangoproject.com/ticket/17210

I'll try to take care of this when time permits.

Original comment by techtonik@gmail.com on 9 Jan 2012 at 8:26

GoogleCodeExporter commented 9 years ago

Original comment by albrecht.andi on 6 Apr 2012 at 6:45