DeanHere / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

ui is horribly broken on touch devices #427

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Try to pan around a code review using a touchscreen.

What is the expected output? What do you see instead?
I expect to scroll through code when I tap and drag. Instead, every tap 
generates an inline comment. It's nearly impossible to read a diff.

What browser are you using?  What version? On what operating system?
Mobile chrome beta on android.

At what URL are you accessing Rietveld?  (e.g. codereview.appspot.com)
Please note if you are using the Google Apps Labs version (e.g.
codereview.<yourdomain>).
chromium codereview

*** If you are a Google employee please say so or mail rietveld-admins@
directly. ***
Yep.

Please provide any additional information below.

Original issue reported on code.google.com by jered@chromium.org on 14 Mar 2013 at 4:15

GoogleCodeExporter commented 9 years ago
I remember there was some pain in doing reviews from Android phones, yes, but I 
am not sure that should be the UI/UX decision.

Original comment by techtonik@gmail.com on 14 Mar 2013 at 8:36

GoogleCodeExporter commented 9 years ago

Original comment by albrecht.andi on 14 Mar 2013 at 8:41

GoogleCodeExporter commented 9 years ago

Original comment by albrecht.andi on 14 Mar 2013 at 8:42

GoogleCodeExporter commented 9 years ago
https://code.google.com/p/rietveld/source/detail?r=a143a5c4b58d54a2f19c0990dfac4
794ded83d1b should have fixed the scrolling (sorry I should have likned to this 
bug).

Original comment by benwells@chromium.org on 11 Jul 2013 at 11:42

GoogleCodeExporter commented 9 years ago

Original comment by albrecht.andi on 12 Jul 2013 at 3:43