search

DeanHere / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

Possibility of having commit message in the diff file #431

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. use upload.py to create a diff file and upload
2. download the raw patch
3. hg import the patch

Is there a chance that we could specify the message inside the diff file (not 
on the issue tracker) ?

Original issue reported on code.google.com by SteveNg....@gmail.com on 20 Mar 2013 at 1:17

GoogleCodeExporter commented 9 years ago 
is there any updates to this?

Original comment by SteveNg....@gmail.com on 27 Mar 2013 at 2:22

GoogleCodeExporter commented 9 years ago 
Commit message could actually be used for the review message. But..

The information is lost when upload.py converts all diffs to SVN format here - 
https://code.google.com/p/rietveld/source/browse/upload.py#1501

A quick glimpse doesn't reveal if any parsing is done on the server side at the 
time upload finishes, and the working format of Patch object seems to be the 
text submitted by upload.py. So we will need two changes to allow that:

1. store raw format in its original form (maybe with original filename)
2. parse the diff on the server side (maybe just validate)

Original comment by techtonik@gmail.com on 27 Mar 2013 at 7:01