Open GoogleCodeExporter opened 9 years ago
Part 2 is (not a well formed patch, the editing feature is failing on me with a
400 error for some reason) -
--- a/templates/file_navigation.html
+++ b/templates/file_navigation.html
{%if patch.next%}
+ {%if not exclude_prerender%}
<link rel="prerender"
href="{%ifequal view_style 'patch'%}{%url codereview.views.patch issue.key.id,patchset.key.id,patch.next.key.id%}{%else%}{%url codereview.views.diff issue.key.id,patchset.key.id,patch.next.filename%}{%endifequal%}{%urlappend_view_settings%}"></link>
+ {%endif%}
<a id="nextFile"
Original comment by phist...@chromium.org
on 1 Jun 2013 at 4:36
Please upload patches to codereview.appspot.com.
To give a short feedback: I don't see where exclude_prerender comes from. I
can't find this variable neither in the default branch nor in the chromium
branch.
Original comment by albrecht.andi
on 1 Jun 2013 at 4:40
It does not come from anywhere, it is defined there exactly for this purpose.
Original comment by phist...@chromium.org
on 1 Jun 2013 at 4:42
Also... if you do not want patches this way, why are you allowing the edit file
feature?
Original comment by phist...@chromium.org
on 1 Jun 2013 at 4:46
The patch was uploaded -
https://codereview.appspot.com/12351044/
Original comment by phist...@chromium.org
on 2 Aug 2013 at 8:47
Original issue reported on code.google.com by
phist...@chromium.org
on 1 Jun 2013 at 4:31Attachments: