DeanHere / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

Better discoverability of comments in old patch sets #456

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
I currently use 2 main flows for dealing with code reviews. The first is to go 
through all the comments on my latest patch the second is to go through all the 
comments in the new messages at the bottom of the main review page.

When getting review responses, a reviewer may have flow-on comments on an old 
patch that I need to address so working through the latest patch's diff won't 
work. It's hard to see that there was a new comment in an old patch set and 
this means that those comments are easy to miss. Working through the main 
message view is inconvenient because I still need to click through to the diff 
view to reply to the comment.

The 2 suggestions I have are:
- inlining the diff view comment reply UI in the messages on the main review 
page so that it's possible to just work through the main page and reply to each 
comment from there
- making it possible to see which patches have comments from a particular 
message (e.g clicking something on the message filters the patch sets view to 
only show patches with comments from that message, changing the number of 
comments etc

Original issue reported on code.google.com by calam...@chromium.org on 19 Jul 2013 at 3:42