DeanHere / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

Searching by Owner on Code Review sometimes returns "Unknown User" when "Newer" is clicked. #459

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Go to https://codereview.chromium.org/search
2. Search for the owner DHNishi@gmail.com (Daniel Nishi)
3. Click "Newer" on the next page.

What is the expected output?
The rest of the code reviews are shown. I can verify that there are more closed 
reviews than what is shown on the first page.

What do you see instead?
The search prompt with all of the options and "Unknown user" in red text above 
Owner, which now reads "DHNishi" rather than "DHNishi@gmail.com"

What browser are you using?  What version? On what operating system?
Successfully repro'd with Ubuntu 12.04 using Chrome 30.0.1588.0 (Official Build 
215786) dev and FireFox 23.0.

At what URL are you accessing Rietveld?
https://codereview.chromium.org/search

Please provide any additional information below.

This issue also occurs if we change the sort to make it show the oldest entries 
first, which would make the "Newer" link make literal sense.

I've also encountered this issue with other Gmail users on Code Search as well, 
but I couldn't find any off-hand that had more than 1 full page of Code 
Reviews. People with @chromium addresses do not seem to have this issue.

It's also worth noting that I could not repro this issue on rietvald's code 
review when I tried looking for closed reviews from Gmail address owners, but I 
was able to repro on the Chromium Code Review. Hopefully this is the right 
place to report this bug.

Original issue reported on code.google.com by DHNishi on 20 Aug 2013 at 5:03

GoogleCodeExporter commented 9 years ago
Looks like a bug in the rendering of the Next link. Want to submit a patch to 
fix this?

Original comment by maruel@chromium.org on 20 Aug 2013 at 5:06