DeanHere / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

upload.py doesn't warn when changing line endings #462

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

1. On Linux, create a file containing \r\n line endings
2. Add to git, commit
3. Use upload.py to send

What is the expected output? What do you see instead?

In all cases when the file is going to be different on the server due to this 
the user would expect a warning, just as it gets by git if git itself would 
change the file due to the config.autocrlf setting.

If the user is not made aware of this it might be the case that the file is 
actually corrupted when uploaded. This will occur for all binary files that 
where not identified as binary files. One example of this is MHTML files, which 
need to use \r\n line endings in the headers.

This problem is made worse by the fact that upload.py doesn't identify files 
such as these as binary files.

Original issue reported on code.google.com by ti...@opera.com on 12 Sep 2013 at 7:19