DeanHere / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

Keyboard shortcuts 'enter' and 'o' do not open issue on dash board. #477

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Go to codereview.chromium.org
2. Use 'j'/'k' to navigate to issue
3. Press enter

What is the expected output? What do you see instead?

Issue should be opened. Nothing happens.

What browser are you using?  What version? On what operating system?

Chrome 33, Linux

Please provide any additional information below.

In the following code (static/script.js:2823) child.firstChild in the while 
loop gives a text node and not an anchor node. Using children[0] in the while 
loop seems to yield the anchor node. 

      ...
    } else if (key == 'O' || key == 'Enter') {
      if (dashboardState) {
    var child = dashboardState.curTR.cells[2].firstChild;
    while (child && child.nodeName != "A") {
      child = child.firstChild;
    }
    if (child) {
      location.href = child.href;
    }
      }
    } else {
      ...

Original issue reported on code.google.com by ager@chromium.org on 22 Feb 2014 at 2:41

GoogleCodeExporter commented 9 years ago
http://www.burbagssale2013.com/  Burberry Outlet
http://www.cheaphollistersale.co.uk/ Cheap Hollister Clothes
http://www.coach-blackfriday.com/ Coach Black Friday
http://www.coach-blackfriday2013.com/ Coach Black Friday 2013
http://www.coach-cybermonday.com/ Coach Cyber Monday
http://www.coach-factoryy.com/ Coach Factory
http://www.coach-outletfactory.com/ Coach Outlet Factory
http://www.coach-outletusa.com/ Coach Outlet USA
http://www.coach-pursesfactory.com/ Coach Purses Factory
http://www.coachpurseusa.com/ Coach Purses USA
http://www.coach-storeoutlet.com/ Coach Store Outlet
http://www.coachxpursesonsale.com/ Coach Purses On Sale
http://www.discountbeatsbydresale.com/ Monster Beats Outlet
http://www.louis-vuittonblackfriday.com/ Louis Vuitton Outlet
http://www.lv-guccishoesfactory.com/ Louis Vuitton Factory
http://www.marcjacobsonsale.com/ Marc Jacobs On Sale
http://www.mcmblackfriday.com/ MCM Outlet
http://www.mcmoutlet-jp.com/ MCM 店铺
http://www.michaelkorsmas.com/ Michael Kors Outlet
http://www.michaelkors.so/ Michael Kors Outlet
http://www.michael-korsfactorystore.com/ Michael Kors Factory
http://www.michaelkorsoutletr.com/ Michael Kors Outlet
http://www.michaellkorsfactoryonline.com/ Michael Kors Factory Online
http://www.newcoachfactory.com/ Coach Factory Outlet
http://www.north-faceoutletonlines.net/ North Face Outlet Online
http://www.polo-outletstore.com/ Polo Outlet Store
http://www.ralphlaurenuker.com/ Ralph Lauren UK
http://www.saclongchamppairs.com/ Sac Longchamp Pairs
http://www.tcoachoutletonline.com/ Coach Outlet Online
http://www.the-coachfactoryoutlet.com/ Coach Factory Oultet
http://www.uggaustralia.cc/ Ugg Australia
http://www.barbour-jacketsoutlet.com/ Barbour Jackets Outlet Online
http://www.canada-gooser.com/ Canada Goose Outlet
http://www.guccishoes-factorys.com/ Gucci Outlet Online
http://www.michaelkorstates.com/ Michael Kors Outlet
http://www.moncler-clearance.com/ Moncler Clearance
http://www.moncler-jacketsoutletonline.com/ Moncler Jackets Outlet Online
http://www.northsclearance.com/ North Clearace Outlet
http://www.ralphxlaurenpolos.com/ Polo Ralph Lauren Outlet Online
http://www.woolrich-clearance.com/ Woolrich Clearance
http://www.cvshopfactory.com/ shop.coachfactory.com
http://www.mksfactoryoutlet.com/ Michael Kors Factory Outlet
http://www.zxcoachoutlet.com/ Coach Outlet Online USA
http://www.mischristmas.com/ Coach Factory Outlet Online
http://www.misblackfriday.com/ Black Friday
http://www.newoutletonlinemall.com/ Coach Purses Outlet Online
http://www.clickmichaelkors.com/ Michael Kors USA
http://www.cmichaelkorsoutlet.com/ Michael Kors Outlet USA
http://www.ralphlaurenepolo.com/ Ralph Lauren Polo

Original comment by shioom...@gmail.com on 2 Apr 2014 at 2:00