DeanIsMe / SevSeg

Seven segment display controller library for Arduino
MIT License
325 stars 130 forks source link

Improve with degree ° #19

Closed alexrtou closed 7 years ago

alexrtou commented 7 years ago

Hello, good Job. It's works realy fine ! just a simple suggestion: can you add degree char ? that's use full for temperatures :)

probably :

static const byte digitCodeMap[] = {
//     GFEDCBA  Segments      7-segment map:
...
     B01100011, // ??  '°'  DEGREE
};
DeanIsMe commented 7 years ago

Hi Alex,

Considering that it can't be easily typed and it doesn't draw well on a seven segment display, I don't think I'll include it in the core library.

It seems that you've already figured out how to add it to your own library though.

-Dean


From: alexrtou notifications@github.com Sent: Thursday, 30 March 2017 12:58:24 AM To: DeanIsMe/SevSeg Cc: Subscribed Subject: [DeanIsMe/SevSeg] Improve with degree ° (#19)

Hello, good Job. It's works realy fine ! just a simple suggestion: can you add degree char ? that's use full for temperatures :)

probably :

static const byte digitCodeMap[] = { // GFEDCBA Segments 7-segment map: ... B01100011, // ?? '°' DEGREE };

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/DeanIsMe/SevSeg/issues/19, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEG7QEbEWweCgjKXgWVvId_C6xw-eCViks5rqnGQgaJpZM4MtG3G.

alexrtou commented 7 years ago

no problem ! it was just an idea.